[FFmpeg-devel] [PATCH] remove illegal riff audio tags from array

[Michael Niedermayer]

On Fri, Jul 02, 2010 at 09:47:09PM -0700, Baptiste Coudurier wrote:
> Hi
>
> $subject.
>
> -- 
> Baptiste COUDURIER
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> FFmpeg maintainer                                  http://www.ffmpeg.org

>  nuv.c  |   10 ++++++++++
>  riff.c |    6 ------
>  2 files changed, 10 insertions(+), 6 deletions(-)
> 8844da25ed0dc07286e1e52d96274e7bce62991b  remove_illegal_riff_audio_tags.patch
> commit aee2aa51f5d781a9605ee89cbbd144a62a8a5fe8
> Author: bcoudurier <baptiste.coudurier at gmail.com>
> Date:   Mon Jun 29 01:14:54 2009 -0700
> 
>     remove illegal riff audio tags, check it in nuv demuxer directly
> 
> diff --git a/libavformat/nuv.c b/libavformat/nuv.c
> index 5e6fca5..fa28e27 100644
> --- a/libavformat/nuv.c
> +++ b/libavformat/nuv.c
> @@ -48,6 +48,12 @@ static int nuv_probe(AVProbeData *p) {
>  //! little macro to sanitize packet size
>  #define PKTSIZE(s) (s &  0xffffff)
>  
> +static const AVCodecTag audio_codec_tags[] = {
> +    { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
> +    { CODEC_ID_MP3,       MKTAG('L', 'A', 'M', 'E') },
> +    { CODEC_ID_MP3,       MKTAG('M', 'P', '3', ' ') },
> +};

should be set in AVInputFormat.codec_tag

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100703/e7352878/attachment.pgp>