[FFmpeg-devel] [PATCH] Tell gcc not to "suggest" unnecessary parentheses

Eli Friedman eli.friedman
Sat Jul 3 21:20:17 CEST 2010


On Thu, Jul 1, 2010 at 2:46 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Jul 01, 2010 at 02:38:43PM +0200, Diego Elio ?Flameeyes? Petten? wrote:
>> Il giorno mer, 30/06/2010 alle 22.17 -0700, Eli Friedman ha scritto:
>> >
>> > Patch attached. ?We should either do this or commit patches like
>> > http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-June/091646.html
>> > to fix the warnings (I don't have a preference either way).
>
> iam slightly in favor of disabling () warnings
>
>
>>
>> If I may give a suggestion, keep the warning as it can help spotting
>>
>> if ( foo = 1 )
>>
>> where the assignment wasn't intended.
>
> does our patcheck check for this?

Not at the moment... I'd write a patch, but my regex skills aren't
quite up to the task.

-Eli



More information about the ffmpeg-devel mailing list