[FFmpeg-devel] [PATCH] H.264 : lowres isn't supported currently so treat a non-zero value as an error.

[Jai Menon]

On Sun, Jul 4, 2010 at 6:22 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Sunday 2010-07-04 17:39:26 +0530, Jai Menon encoded:
>> ---
>> ?libavcodec/h264.c | ? ?5 +++++
>> ?1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/libavcodec/h264.c b/libavcodec/h264.c
>> index 1054286..5d9ef89 100644
>> --- a/libavcodec/h264.c
>> +++ b/libavcodec/h264.c
>> @@ -903,6 +903,11 @@ av_cold int ff_h264_decode_init(AVCodecContext *avctx){
>> ? ? ?H264Context *h= avctx->priv_data;
>> ? ? ?MpegEncContext * const s = &h->s;
>>
>> + ? ?if (avctx->lowres) {
>> + ? ? ? ?av_log(avctx, AV_LOG_ERROR, "lowres decoding isn't supported by the H.264 decoder\n");
>> + ? ? ? ?return -1;
>
> AVERROR(EINVAL)

I dount if EINVAL is any better in this case, but I'll change it if you want.

> or maybe AVERROR_PATCHWELCOME,

Do we really want a patch for this ? :) Based on what I've read on
-devel earlier, quality might be very bad (if somebody does get it
working). Either way, I'll change it to whatever Michael wants.

> also "is not" is favored over "isn't".

right, I'll change it before committing.

-- 
Jai Menon