[FFmpeg-devel] [PATCH] H.264 : lowres isn't supported currently so treat a non-zero value as an error.

Jai Menon jmenon86
Mon Jul 5 07:03:33 CEST 2010


On Mon, Jul 5, 2010 at 1:31 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Jul 04, 2010 at 06:25:06PM +0000, Carl Eugen Hoyos wrote:
>> Jai Menon <jmenon86 <at> gmail.com> writes:
>>
>> > diff --git a/libavcodec/h264.c b/libavcodec/h264.c
>> > index 1054286..5d9ef89 100644
>> > --- a/libavcodec/h264.c
>> > +++ b/libavcodec/h264.c
>> > @@ -903,6 +903,11 @@ av_cold int ff_h264_decode_init(AVCodecContext *avctx){
>> > ? ? ?H264Context *h= avctx->priv_data;
>> > ? ? ?MpegEncContext * const s = &h->s;
>> >
>> > + ? ?if (avctx->lowres) {
>>
>> Since this affects many decoders (and for the remaining ones, there usually is a
>> limit, and they crash if it is exceeded), could this be solved more generally.
>>
>> My naive idea was to add the maximum value to struct AVCodec, and assume 0 as
>> default value.
>
> ok, as int8_t probably would be best to avoid wasting space

okay, patch withdrawn. i hope the other approach is implemented
quickly since the segfault affects all user applications too.

-- 
Jai Menon



More information about the ffmpeg-devel mailing list