[FFmpeg-devel] [PATCH] GSM 6.10 audio decoder

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, Jul 05, 2010 at 09:47:02AM -0400, Ronald S. Bultje wrote:
>> Hi,
>> 
>> On Sat, Jul 3, 2010 at 7:03 PM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
> [...]
>
>> > +AVCodec gsm_decoder = {
>> > +    "gsm",
>> > +    AVMEDIA_TYPE_AUDIO,
>> > +    CODEC_ID_GSM,
>> > +    sizeof(GSMContext),
>> > +    gsm_init,
>> > +    NULL,
>> > +    NULL,
>> > +    gsm_decode_frame,
>> > +    .long_name = NULL_IF_CONFIG_SMALL("GSM"),
>> > +};
>> > +
>> > +AVCodec gsm_ms_decoder = {
>> > +    "gsm_ms",
>> > +    AVMEDIA_TYPE_AUDIO,
>> > +    CODEC_ID_GSM_MS,
>> > +    sizeof(GSMContext),
>> > +    gsm_init,
>> > +    NULL,
>> > +    NULL,
>> > +    gsm_decode_frame,
>> > +    .long_name = NULL_IF_CONFIG_SMALL("GSM Microsoft variant"),
>> > +};
>> 
>> You could use a macro here to decrease source code size.
>
> i think thats obfuscating it a bit too much but that are just my 10cent
> its the maintainers decission of course not mine

For just the two instances, I wouldn't bother with a macro.

-- 
M?ns Rullg?rd
mans at mansr.com