[FFmpeg-devel] [PATCH] Fix compilation of FASTDIV() with llvm-gcc on x86_64
Mon Jul 5 19:53:18 CEST 2010
On Mon, Jul 05, 2010 at 06:45:38PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > On Mon, Jul 05, 2010 at 02:54:09PM +0100, Mans Rullgard wrote:
> >> LLVM requires matching input and output asm parameters to have the
> >> same type. For the FASTDIV macro, an (int) cast on the input fixes
> >> this trivially.
> > Uh, where is a different type than int used with FASTDIV?
> > I am not at all convinced those uses are really correct.
> vorbis_dec.c line 1329.
partition_size being uint32t_fast seems completely pointless to me,
it is not used for array indexing, so uint32_t should be just as fast
on any architecture I am aware of.
More information about the ffmpeg-devel