[FFmpeg-devel] [misc-filters PATCH 4/8] Factorize out some code and implement the fill_line_with_color() function. Allow to share code with the pending color source.
Wed Jul 7 00:15:33 CEST 2010
On date Tuesday 2010-07-06 12:01:02 +0100, M?ns Rullg?rd encoded:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Thu, Jul 01, 2010 at 10:50:08PM +0200, Stefano Sabatini wrote:
> >> ---
> >> libavfilter/vf_pad.c | 106 ++++++++++++++++++++++++++-----------------------
> >> 1 files changed, 56 insertions(+), 50 deletions(-)
> > if you checked that this just moves code around then ok
> It also replaces RGB_TO_[YUV]_CCIR with plain RGB_TO_[YUV]. I assume
> this is a mistake.
I know how I messed it up, I copied code from the color source, which
was pretty old code which was written when the pad filter was not
still using _CCIR, I didn't noticed it when reading the patch (which I
did not less than five times), and the lavfitest was passing anyway.
Thanks for fixing, regards.
FFmpeg = Frenzy and Fabulous Multipurpose Picky Erroneous Governor
More information about the ffmpeg-devel