[FFmpeg-devel] [misc-filters PATCH 2/8] Move av_parse_frame_size() and av_parse_frame_rate() from libavcodec to libavutil. This way they can be used without to require a dependency on libavcodec.

Michael Niedermayer michaelni
Wed Jul 7 14:31:57 CEST 2010


On Wed, Jul 07, 2010 at 12:24:18AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2010-07-06 14:31:05 +0200, Michael Niedermayer encoded:
> > On Sat, Jul 03, 2010 at 10:13:07PM +0200, Stefano Sabatini wrote:
> > > On date Saturday 2010-07-03 22:06:15 +0200, Michael Niedermayer encoded:
> > > > On Sat, Jul 03, 2010 at 09:47:10PM +0200, Stefano Sabatini wrote:
> > > > > On date Friday 2010-07-02 00:04:32 +0200, Michael Niedermayer encoded:
> > > > > > On Thu, Jul 01, 2010 at 10:41:05PM +0200, Stefano Sabatini wrote:
> > > > > > > ---
> > > > > > >  libavcodec/avcodec.h |   24 ---------
> > > > > > >  libavcodec/utils.c   |  127 --------------------------------------------------
> > > > > > >  libavutil/avutil.h   |   24 +++++++++
> > > > > > >  libavutil/utils.c    |  127 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > > > >  4 files changed, 151 insertions(+), 151 deletions(-)
> > > > > > 
> > > > > > this stuff imho does not belong to libavutil.
> > > > > > but whatever #if vsrc_movie needs should be enough for this
> > > > > 
> > > > > I'm not sure you're approving this patch, another variant in
> > > > > attachment. I prefer this one as it doesn't clutter avutil.h.
> > > > 
> > > > vsrc_movie can use libavformat
> > > > libavformat depends on libavcodec
> > > > so filters can use libavcodec under whatever #ifdef vsrc_movie is
> > > 
> > > My plan was to use this functions for other sources as well, for
> > > example for the color source, and I don't want to make it depends on
> > > lavc only for these functions.
> > > 
> > 
> > > Also the functions look generic enough to deserve a place in lavu.
> > 
> > i dont want them in lavu, they dont belong there
> 
> Could you elaborate on this? Where should they stay if not in lavu?

libavutil is supposed to be a small generic util lib.
video width/height belong in it as much as car manufactor lists.
maybe we need a libavcommon for all the common multimedia code that is
not multimedia independant utils.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100707/5fad34ef/attachment.pgp>



More information about the ffmpeg-devel mailing list