[FFmpeg-devel] [implement-pixdesctest PATCH] Rename read_line() and write_line() to av_read_image_data_line and av_write_image_data_line().

Michael Niedermayer michaelni
Thu Jul 8 00:56:40 CEST 2010


On Thu, Jul 08, 2010 at 12:22:10AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2010-07-07 22:41:27 +0100, M?ns Rullg?rd encoded:
> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> > 
> > > The old names were not av_ prefixed, and they were causing linking
> > > failure on many platforms.
> > > ---
> > >  libavfilter/vf_pixdesctest.c |    4 ++--
> > >  libavutil/pixdesc.c          |    4 ++--
> > >  libavutil/pixdesc.h          |    8 ++++----
> > >  3 files changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/libavfilter/vf_pixdesctest.c b/libavfilter/vf_pixdesctest.c
> > > index 871be30..3c1dab3 100644
> > > --- a/libavfilter/vf_pixdesctest.c
> > > +++ b/libavfilter/vf_pixdesctest.c
> > > @@ -90,13 +90,13 @@ static void draw_slice(AVFilterLink *inlink, int y, int h, int slice_dir)
> > >          int y1 = c == 1 || c == 2 ? y>>priv->pix_desc->log2_chroma_h : y;
> > >
> > >          for (i = y1; i < y1 + h1; i++) {
> > > -            read_line(priv->line,
> > > +            av_read_image_data_line(priv->line,
> > 
> > New name seems a bit long.  What would you read/write if not data?
> 
> av_read_image_line
> av_write_image_line 

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100708/b466707b/attachment.pgp>



More information about the ffmpeg-devel mailing list