[FFmpeg-devel] [PATCH] Add "unofficial" FATE tests

Måns Rullgård mans
Fri Jul 9 01:51:14 CEST 2010


Vitor Sessak <vitor1001 at gmail.com> writes:

> On 07/09/2010 01:34 AM, M?ns Rullg?rd wrote:
>> Vitor Sessak<vitor1001 at gmail.com>  writes:
>>
>>> On 07/09/2010 01:14 AM, M?ns Rullg?rd wrote:
>>>> Vitor Sessak<vitor1001 at gmail.com>   writes:
>>>>
>>>>> On 07/09/2010 12:51 AM, M?ns Rullg?rd wrote:
>>>>>> Vitor Sessak<vitor1001 at gmail.com>    writes:
>>>>>>
>>>>>>> The attached patch add support for adding to "make fate" new tests
>>>>>>> that are not yet integrated in Mike's database. It add two new targets:
>>>>>>>
>>>>>>> - "make fate1" does all the tests in Mike's database
>>>>>>> - "make fate2" does all the tests described in tests/fate2.mak
>>>>>>> - "make fate" is an alias for "make fate1 fate2"
>>>>>>
>>>>>> Do we really need to split it like that?
>>>>>
>>>>> This way Mike can add a FATE test that runs "make fate2" in the same
>>>>> way he has one that runs "make test".
>>>>
>>>> That's a bad idea.  We don't want to lump lots of tests together like
>>>> that.
>>>
>>> Both "make fate" and "make test" lump lots of tests together today, no?
>>
>> That's a convenience for manual use only.  Running the bulk tests as a
>> single FATE item is bad.  FATE does that with "make test" for
>> historical reasons only.  It would be easy to split it now.
>
> Now I see what you are talking about. Ideally, tests should not live
> in "make test2" for long, just until they get their own test spec and
> go to the main "make fate".

I still don't see the point of having a separate target to run the
non-Mike tests only.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list