[FFmpeg-devel] [PATCH] Add a MAXDIST parameter to tiny_psnr (for 1-off fate tests)

Michael Niedermayer michaelni
Fri Jul 9 15:47:57 CEST 2010


On Thu, Jul 08, 2010 at 10:07:09PM +0200, Vitor Sessak wrote:
> On 07/08/2010 09:53 PM, Jason Garrett-Glaser wrote:
>> On Thu, Jul 8, 2010 at 11:56 AM, Vitor Sessak<vitor1001 at gmail.com>  wrote:
>>> On 07/08/2010 08:51 PM, Ronald S. Bultje wrote:
>>>>
>>>> Hi,
>>>>
>>>> On Thu, Jul 8, 2010 at 2:47 PM, Vitor Sessak<vitor1001 at gmail.com>    
>>>> wrote:
>>>>>
>>>>> $subj, it is necessary to get FATE to test float-based codecs (at least
>>>>> locally through "make fate") by checking if MAXDIST == 1. Comments are
>>>>> welcome.
>>>>
>>>> [..]
>>>>>
>>>>> +            dist = a-b;
>>>>> +            dist = dist<    0 ? -dist : dist;
>>>>
>>>> FFABS().
>>>
>>> That would add a new dependency on lavu to it, what is not the case until
>>> now.
>>
>> What about, just... abs()?
>
> Indeed, it is already used elsewhere (thus present in all supported archs). 
> New patch attached.
>
> -Vitor

>  tiny_psnr.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 7ee3107d71082abc3cd3f5c82d247c150ac9ac4f  one-off_2.diff

fine with me

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100709/31b56491/attachment.pgp>



More information about the ffmpeg-devel mailing list