[FFmpeg-devel] [PATCH] add avsubtitle_free

[Michael Niedermayer]

On Sat, Jul 10, 2010 at 10:59:17PM +0200, Reimar D?ffinger wrote:
> On Sat, Jul 10, 2010 at 10:21:04PM +0200, Michael Niedermayer wrote:
> > do we want subtitles to be handled differently?
> > if yes, then your patch is ok
> > if no, well ...
> > 
> > it might make sense if our subtitle decoders could via a get_buffer()
> > equivalent draw subtitles directly into some player buffer that will
> > be displayed. But maybe this becomes too convoluted, i dont know
> > 
> > but as said ive not had time to think about this as much as one
> > should to make a good suggestion about which way to go.
> > 
> > also if there ever is a subtitle decoder that has P frames, a
> > system closer to video codecs will be more efficient.
> 
> Well, I think subtitles have enough complexities, also due to
> num_rects a get_buffer/release_buffer would have to support a lot
> more "outstanding" frames than for video, so it would be different
> anyway.

ok but please document this difference between video & subtitles somewhere
explicitly with the reasoning. Otherwise people might use it to say the
api design is an inconsistant mess


> Also more than one subtitle frame per second is unrealistic, which
> means that efficiency is not that important and P-frames are unlikely
> to be used since that works too bad with seeking.

depends, ive seen songs with lyrics in subtitles that showed effects
per letter and that surely where more updates than 1 per second


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100710/9ff6a3c1/attachment.pgp>