[FFmpeg-devel] [RFC] libavfilter audio framework - split patches

[S.N. Hemanth Meenakshisundaram]

> On date Sunday 2010-07-11 16:47:21 +0200, Michael Niedermayer encoded:
>> On Sun, Jul 11, 2010 at 06:58:15AM -0700, S.N. Hemanth Meenakshisundaram
>> wrote:
>> > S.N. Hemanth Meenakshisundaram wrote:
>> >>
>> >> I am sending out the working lavfi audio patches in the order Stefano
>> >> requested for easy committing. [...]
>>
>> duplicate of avfilter_ref_pic()
>>
>> duplicate of avfilter_unref_pic()
>>
>> duplicate of avfilter_get_video_buffer()

For these 3 functions using macros, I will factorize using macros as
Stefano suggested since the functions take different type/number of
arguments.

>>
>> duplicate avfilter_request_frame()

For this one, I will eliminate request_samples completely.

>
> OK I indeed have the same concerns. I see two ways for fixing this:
> implementing some form of heiry macros, *or* generalize the code.
>
> Regards.
> --

Also attached are the new patches for generalization that go on top of
existing libavfilter code before any audio stuff.

First patch makes formats an int in the avfilter structures instead of
enum PixelFormat.

Second patch (on top of first) makes AVFilterPic into AVFilterBuffer,
removes w and h from it, makes required code changes and makes the
AVFilterBUffer's format field an int instead of PixelFormat.

Regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pre_aud.diff
Type: text/x-patch
Size: 3073 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100712/4fdf1dea/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pic2buffer.diff
Type: text/x-patch
Size: 3145 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100712/4fdf1dea/attachment-0001.bin>