[FFmpeg-devel] [PATCH] libvpx: deadline & profile support

[Michael Niedermayer]

On Mon, Jul 12, 2010 at 04:23:04PM -0400, James Zern wrote:
> On Sun, Jul 11, 2010 at 08:58, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> + ? ?switch (FFABS(avctx->level) / 100) {
> >> + ? ?case 1:
> >> + ? ? ? ?ctx->deadline = VPX_DL_BEST_QUALITY;
> >> + ? ? ? ?break;
> >> + ? ?case 2:
> >> + ? ?default:
> >> + ? ? ? ?ctx->deadline = VPX_DL_GOOD_QUALITY;
> >> + ? ? ? ?break;
> >> + ? ?case 3:
> >> + ? ? ? ?ctx->deadline = VPX_DL_REALTIME;
> >> + ? ? ? ?break;
> >> + ? ?}
> >> + ? ?av_log(avctx, AV_LOG_DEBUG, "Using deadline: %lu\n", ctx->deadline);
> >
> > avctx->level and ctx->deadline seem to differ in semantics, so iam not
> > in favor of this
> 
> That's fair, I didn't see a great mapping for these though. Would they
> warrant new parameters? Maybe a flags2 for error resilience?

once we support codec specific options this should be easier and cleaner
possible.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100712/8d4fede2/attachment.pgp>