[FFmpeg-devel] [PATCH] rtsp: remove TODO that referred to faad (now banished)

[Reimar Döffinger]

On Wed, Jul 14, 2010 at 01:45:19PM +0200, Luca Barbato wrote:
> On 7/14/10 12:18 PM, Diego Elio 'Flameeyes' Petten? wrote:
> >---
> >  libavformat/rtsp.c |    4 ----
> >  1 files changed, 0 insertions(+), 4 deletions(-)
> >
> >diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> >index 9316f3c..877e359 100644
> >--- a/libavformat/rtsp.c
> >+++ b/libavformat/rtsp.c
> >@@ -139,10 +139,6 @@ static int sdp_parse_rtpmap(AVFormatContext *s,
> >              i = atoi(buf);
> >              if (i>  0)
> >                  codec->channels = i;
> >-            // TODO: there is a bug here; if it is a mono stream, and
> >-            // less than 22000Hz, faad upconverts to stereo and twice
> >-            // the frequency.  No problem, but the sample rate is being
> >-            // set here by the sdp line. Patch on its way. (rdm)
> >          }
> >          av_log(s, AV_LOG_DEBUG, "audio samplerate set to: %i\n",
> >                 codec->sample_rate);
> 
> has been tested that it doesn't happen on ffaac as well?

Well, I don't really understand what the problem here is, but also
people might be using libavformat/rtsp with libfaad even though
the wrapper was removed (e.g. MPlayer can do this).