[FFmpeg-devel] [PATCH] Add WebM to the Matroska demuxer name
Thu Jul 15 20:57:14 CEST 2010
Baptiste Coudurier <baptiste.coudurier at gmail.com> writes:
> On 07/15/2010 10:32 AM, M?ns Rullg?rd wrote:
>> Reimar D?ffinger<Reimar.Doeffinger at gmx.de> writes:
>>> On Thu, Jul 15, 2010 at 01:58:58AM -0400, Alex Converse wrote:
>>>> Some users are getting confused. We do a similar thing for
>>> And I've always considered it a bad idea.
>>> Changing this field means the value you need to use for -f changes
>>> (and MPlayer actually also relies on this name), so strictly speaking
>>> this would require a major version bump.
>> -f matroska,webm would be nothing short of ridiculous.
> WTF, for demuxers, values are matched between commas. Mans, you even
> reviewed that patch.
I forgot about that, and now I come to think it was probably not such
a good idea. It will break any application which enumerates the
demuxers and does something with the name, and as such this should be
considered an ABI break.
The correct solution is to make that field a proper array like we have
for some other properties. To avoid breaking ABI, we could even add
a list of aliases at the end of the struct. The single name field
could be dropped at the next big break if we want to.
mans at mansr.com
More information about the ffmpeg-devel