[FFmpeg-devel] [PATCH] Fix function parameters for rgb48 to YV12 functions.

[Ramiro Polla]

On Mon, May 10, 2010 at 9:37 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> On Tue, May 4, 2010 at 9:31 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Tue, May 04, 2010 at 07:29:09PM -0300, Ramiro Polla wrote:
>>> On Fri, Mar 12, 2010 at 8:29 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>>> > On Tue, Mar 2, 2010 at 7:16 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> >> On Wed, Feb 24, 2010 at 12:49:13AM -0300, Ramiro Polla wrote:
>>> [...]
>>> >>> ?bfin/internal_bfin.S | ? ?8 +-
>>> >>> ?bfin/swscale_bfin.c ?| ? ?8 +-
>>> >>> ?colorspace-test.c ? ?| ? ?2
>>> >>> ?rgb2rgb.c ? ? ? ? ? ?| ?172 +++++++++++++++++++++++++--------------------------
>>> >>> ?rgb2rgb.h ? ? ? ? ? ?| ?146 +++++++++++++++++++++----------------------
>>> >>> ?rgb2rgb_template.c ? | ?154 ++++++++++++++++++++++-----------------------
>>> >>> ?swscale.c ? ? ? ? ? ?| ? 20 ++---
>>> >>> ?swscale_internal.h ? | ? 18 ++---
>>> >>> ?swscale_template.c ? | ? 57 ++++++++--------
>>> >>> ?9 files changed, 293 insertions(+), 292 deletions(-)
>>> >>> 04410ad4397e17866d30731b02fab4728526f5f7 ?use_int.diff
>>> >>> diff --git a/bfin/internal_bfin.S b/bfin/internal_bfin.S
>>> >>
>>> >> many of the functions changed are used by applications directly
>>> >> (i remember them in mplayer) so this breaks ABI
>>> >
>>> > Maybe MPlayer should stop using functions that aren't in the API...
>>> >
>>> > Anyways new patch attached doesn't change the rgb2rgb functions used by MPlayer.
>>>
>>> Patch updated to latest SVN.
>>
>> do what you want with the int <-> long as long as it has been benchmarked
>> and is not slower on x86_64
>
> Applied.

I'm finally back on this issue. I had committed and then reverted this
because there were some failures. My revert commit log reads:
"Revert r31153. It failed to build on:
x86_64 / Mac OS X gcc 4.0.1
x86_64 / Linux icc (all)
x86_64 / Linux gcc 4.0.4
x86_64 / OpenBSD gcc 3.3.5
x86_64 / Linux suncc 5.10
and there are some reports of crashes."

Unfortunately I don't remember where the crash reports were (IIRC dark
shikari pointed me to one on irc and there was one that seemed related
on roundup, but I could not find it). I did catch some crashes with
the intel 64-bit compiler and fixed them.

Attached patch was tested to build and run swscale-test on:
i686-pc-mingw32 gcc 4.4.4
i686-w64-mingw32 gcc 4.4.4
x86_64-w64-mingw32 gcc 4.4.4
suncc 5.10
gcc 4.4.3-4ubuntu5 (32-bit, 64-bit, and with asm disabled)
llvm64 2.7
icc 11.1 (32- and 64-bit)

Differences from the previous patch are more uses of "x86_reg
dstW_reg;" and similar. Just look for "_reg" in the patch, the rest is
the same as the previous one.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_int-4.diff
Type: application/octet-stream
Size: 24585 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100717/66d1d27b/attachment.obj>