[FFmpeg-devel] [PATCH] Lego Mindstorms RSO de/muxer (copied from au.c)

Michael Niedermayer michaelni
Tue Jul 20 15:34:16 CEST 2010


On Sun, Jul 18, 2010 at 07:36:56PM +0200, Rafa?l Carr? wrote:
> On Sun, 18 Jul 2010 19:13:26 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Sun, Jul 18, 2010 at 05:37:13PM +0200, Rafa?l Carr? wrote:
> > [...]
> > > +static int rso_read_header(AVFormatContext *s, AVFormatParameters
> 
> > > +    st->duration            = (size * 8) >> av_log2(bps);
> > 
> > why not 
> > st->duration            = (size * 8) / bps ?
> 
> I thought I could spare an expensive division since bps is always 4 or 8

how many millions of files do you plan to open per second?
This is in the header reading code

anyway, patch ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100720/2673c501/attachment.pgp>



More information about the ffmpeg-devel mailing list