[FFmpeg-devel] [PATCH 5/7] Make the ffmpeg output video sink explicitely set the timebase.

Stefano Sabatini stefano.sabatini-lala
Thu Jul 22 16:39:20 CEST 2010

On date Thursday 2010-07-22 14:13:15 +0200, Michael Niedermayer encoded:
> On Wed, Jul 21, 2010 at 05:59:11PM +0200, Stefano Sabatini wrote:
> > This guarantees that the timestamps of the filtered frames are
> > correctly rescaled, in the case a time base change happened in the
> > filterchain.
> this doesnt sound correct.
> If a filter changed the timebase then ffmpeg should use the new timebase
> in the muxer

Note that current code assumes that the output timestamps from the
filtergraph have the same timebase of the input source.

Anyway I see that since we have to rescale anyway when we put the
frames in the output, it is better to avoid a possible unnecessary
(and potentially lossy) conversion. We can detect the filterchain sink
timebase by directly inspecting its input pad after configuration.

I'll work on a patch for that.

FFmpeg = Frightening & Free Mystic Powered Epic Goblin

More information about the ffmpeg-devel mailing list