[FFmpeg-devel] [PATCH] swscale-test: add md5 output

[Reimar Döffinger]

On Sat, Jul 24, 2010 at 06:43:20PM +0100, M?ns Rullg?rd wrote:
> Ramiro Polla <ramiro.polla at gmail.com> writes:
> 
> > On Fri, Jul 23, 2010 at 9:59 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Fri, Jul 23, 2010 at 06:54:15PM -0300, Ramiro Polla wrote:
> >>> $subj, to be used for regression tests. sse is still default.
> >>> (indentation will be done afterwards)
> >>
> >> knowing how similar the output is to the input is usefull as well as its
> >> usefull to know if they differ on 2 computers
> >
> > -sse is still left as an option to be run separately, or do you want
> > both strings to be printed out?
> >
> >> btw, crc should be slightly faster than md5...
> >
> > New patch attached used av_adler32_update().
> 
> Wasn't it just recently someone advocated sha1 over md5 (in the
> context of the md5 muxer iirc), the latter allegedly not strong
> enough?

IMO that was more a theoretical discussion.
I did argue that a CRC is not really enough for e.g. a muxer
which calculates a single number for a full file.
I can't imagine it really matters much for rather limited
regression tests on not that much data and where you always
run more than just one single test so going for speed seems
reasonable (though I guess only of there's actually a relevant
speed difference).