[FFmpeg-devel] [PATCH] libavcodec/wmavoice.c: local variablepow might mask pow function

[Axel Holzinger]

Hi M?ns et al,

On Sun, Jul 25, 2010 at 7:51 PM, M?ns Rullg?rd:
> "Axel Holzinger" <aholzinger at gmx.de> writes:
> 
> > Hi,
> >
> > in libavcodec/wmavoice.c local variable float pow (line 
> 585) can mask 
> > pow function if powf (line 595) is a #define and defined 
> for example 
> > like
> > #define powf(x,y)   ((float)pow((double)(x), (double)(y)))
> 
> But we never do that.

No, you don't do that. Why should you?

But some C library implementations do that. How could you know they
don't?

IMHO using pow as a variable name is at least risky. To me it's not a
good idea to name a variable like a runtime function name.

So pwr instead of pow makes more sense to me. And it doesn't hurt,
does it?

Just my 0.02$
Axel