[FFmpeg-devel] [PATCH] Move av_parse_frame_size() and av_parse_frame_rate() from libavcodec to libavcore

[Michael Niedermayer]

On Sun, Jul 25, 2010 at 11:47:16PM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-07-25 17:26:00 +0200, Stefano Sabatini encoded:
> > On date Sunday 2010-07-25 14:14:36 +0200, Stefano Sabatini encoded:
> > > On date Sunday 2010-07-25 12:57:16 +0200, Michael Niedermayer encoded:
> > > > On Sun, Jul 25, 2010 at 12:51:16PM +0200, Stefano Sabatini wrote:
> > > [...]
> > > > > I don't see why this is necessary, the function was already public,
> > > > > doing it after or before makes no difference (apart from wasting my
> > > > > time, which I'd like to avoid).
> > > > 
> > > > I wasnt conciously aware that this function was public and used, if so you
> > > > will have to deal with the linker-versioning-workaround machinery.
> > > > reinhard should be able to explain how to do that without triggering
> > > > assert(0) in the linker
> > > 
> > > What about exporting the function as an av_parse_video_frame_size2()
> > > symbol in lavcore, and making lavc:av_parse_video_frame_size() depend
> > > on that?
> > > 
> > > That would have a performance hit, given the function is not
> > > performance-critical at all that shouldn't be a problem though.
> > 
> > So after more thought, that may work like this:
> > libavcodec/av_parse_video_frame_size() -> libavcore/av_parse_video_size()
> > libavcodec/av_parse_video_frame_rate() -> libavcore/av_parse_video_rate()
> > 
> > so we avoid ugly "2" suffixes and we end with a less awkward names.
> 
> Patch updated.

as its a new function now, theres no excuse to keep the =0 success case

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100726/90f66f9e/attachment.pgp>