[FFmpeg-devel] [PATCH] mxfenc: avoid redundant redeclaration warning

Reimar Döffinger Reimar.Doeffinger
Tue Jul 27 22:30:36 CEST 2010


Hello,
some compilers (e.g. Apple gcc 4.0.1) create a "redundant redeclaration"
warning due to this.
I think it might be a good idea anyway, because after the change if
someone changes the name of the real declaration it will result in
a linker error, with the current code everything would compile work fine
except that all the comparisions would be broken.
Index: libavformat/mxfenc.c
===================================================================
--- libavformat/mxfenc.c        (revision 24552)
+++ libavformat/mxfenc.c        (working copy)
@@ -44,7 +44,7 @@
 static const int NTSC_samples_per_frame[] = { 1602, 1601, 1602, 1601, 1602, 0 };
 static const int PAL_samples_per_frame[]  = { 1920, 0 };
 
-AVOutputFormat mxf_d10_muxer;
+extern AVOutputFormat mxf_d10_muxer;
 
 #define EDIT_UNITS_PER_BODY 250
 #define KAG_SIZE 512



More information about the ffmpeg-devel mailing list