[FFmpeg-devel] [PATCH] libvpx: rc buffer support

Michael Niedermayer michaelni
Wed Jul 28 01:49:58 CEST 2010


On Mon, Jul 26, 2010 at 03:39:11PM -0400, James Zern wrote:
> On Thu, Jul 22, 2010 at 08:26, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Jun 14, 2010 at 04:06:51PM -0400, James Zern wrote:
> >> The attached maps libvpx rc_buf* and rc_undershoot_pct.
> >> rc_overshoot_pct is unused by VP8 so it is left untouched.
> >> There didn't seem to be a direct mapping for rc_optimal_buf_sz so
> >> instead of introducing a new parameter this sets it in line with the
> >> recommended settings and library defaults (5/6 of the buffer_size).
> >> The use of rc_buffer_aggressivity for rc_undershoot_pct may be
> >> questionable, so if there's something more correct that I missed
> >> please let me know. It does also alter the library default from 95 to
> >> 100, but again this is more along the line of the recommended values
> >> for VBR.
> >
> > if you send a patch that just sets things that match in sematic meaning
> > il approve it.
> > The rest should be handled via codec specific options once they are in
> > svn
> >
> The attached drops the rc_undershoot_pct mapping. The rc_buf_*
> settings are I believe correct in using
> rc_buffer_size/rc_initial_buffer_occupancy.

if you say this is correct, i belive you
patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100728/78750da1/attachment.pgp>



More information about the ffmpeg-devel mailing list