[FFmpeg-devel] [PATCH] id3v2: always skip padding

Michael Niedermayer michaelni
Wed Jul 28 05:54:41 CEST 2010


On Wed, Jul 28, 2010 at 11:29:36AM +1000, Alexander Kojevnikov wrote:
> On 28 July 2010 01:14, Michael Niedermayer <michaelni at gmx.at> wrote:
> > no
> > look at the code:
> >
> > ? ? ? ?len -= taghdrlen + tlen;
> > ...
> > ? ? ? ?next = url_ftell(s->pb) + tlen;
> >
> > ? ? ? ?if (tag[0] == 'T')
> > ? ? ? ? ? ?read_ttag(s, tlen, tag);
> > ? ? ? ?else if (!tag[0]) {
> > ? ? ? ? ? ?if (tag[1])
> > ? ? ? ? ? ? ? ?av_log(s, AV_LOG_WARNING, "invalid frame id, assuming padding");
> > ? ? ? ? ? ?url_fskip(s->pb, len);
> > ? ? ? ? ? ?break;
> > ? ? ? ?}
> > ? ? ? ?/* Skip to end of tag */
> > ? ? ? ?url_fseek(s->pb, next, SEEK_SET);
> >
> >
> > tlen is subtracted from len but its not read or skiped in any way in the
> > break case above
> 
> I see now, attached patch fixes this.

>  id3v2.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 01551d0c5ff96b05b46ae5fc89238964aaba4038  0001-id3v2-always-skip-padding.patch
> From 4657c0738beca2a6815c6edc479f8bef0b3426da Mon Sep 17 00:00:00 2001
> From: Alexander Kojevnikov <alexander at kojevnikov.com>
> Date: Wed, 28 Jul 2010 11:26:52 +1000
> Subject: [PATCH] id3v2: always skip padding

looks good

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100728/00f5e7a8/attachment.pgp>



More information about the ffmpeg-devel mailing list