[FFmpeg-devel] [PATCH] id3v2 unsynchronisation support

[Michael Niedermayer]

On Tue, Jul 27, 2010 at 07:50:48PM +1000, Alexander Kojevnikov wrote:
[...]
> @@ -183,15 +186,15 @@ void ff_id3v2_parse(AVFormatContext *s, int len, uint8_t version, uint8_t flags)
>          goto error;
>      }
>  
> -    if (flags & 0x80) {
> -        reason = "unsynchronization";
> -        goto error;
> -    }
> +    unsync = (flags & 0x80) != 0;

the  () != 0 is unneeded

[...]
> +                if (!buffer_size) {
> +                    buffer = av_malloc(tlen);
> +                    buffer_size = tlen;
> +                } else if (buffer_size < tlen) {
> +                    buffer = av_realloc(buffer, tlen);
> +                    buffer_size = tlen;
> +                }

why not just
av_malloc()

btw, is this buffer freed too ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100728/635eda7d/attachment.pgp>