[FFmpeg-devel] [PATCH] configure libvpx check version of decoder only

Måns Rullgård mans
Sat Jul 31 18:55:23 CEST 2010


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi Frank,
>
> On Thu, Jul 29, 2010 at 3:28 AM, Frank Barchard <fbarchard at google.com> wrote:
>> This patch allows ffmpeg to configure and build against libvpx when it
>> just contains the decoder.
>> libvpx version checked, but only for the decoder.
> [..]
>> -enabled libvpx     && { check_lib2 "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_dec_init_ver -lvpx &&
>> -                        check_lib2 "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_enc_init_ver -lvpx ||
>> +enabled libvpx     && { check_lib2 "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_dec_init_ver -lvpx ||
>>                        die "ERROR: libvpx version must be >=0.9.1"; }
>
> Current behaviour of configure:
> A) if libvpx is enabled, enable fflibvpx decoder wrapper and fflibvpx
> encoder wrapper
> B) each can be turned off manually using their respective switches also
> C) configure fails if encoder and decoder symbols are not found,
> regardless of which fflibvpxenc/dec are enabled. Die if not found.
>
> What this patch does:
> (A-B of above remain in place)
> C) check for decoder symbols only instead of both encoder and decoder
> symbols, still regardless of which fflibvpxenc/dec are enabled. Die if
> not found.
>
> What you should do:
> (A-B of above remain in place)
> C) if fflibvpxdec is enabled, check for decoder symbols.
> D) if fflibvpxenc is enabled, check for encoder symbols.
> E) you could arguably say that if someone has encoder-only or
> decoder-only libvpx installed, he would want only that one enabled in
> ffmpeg. Therefore, Die if C AND D fail. If C OR D fail, disable the
> failing fflibvpxenc/dec wrapper.

Since the libvpx decoding support is temporary, I don't consider this
worth the effort.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list