[FFmpeg-devel] [PATCH] Replace ASMALIGN() with .p2align

Måns Rullgård mans
Wed Jun 2 20:46:41 CEST 2010

Michael Niedermayer <michaelni at gmx.at> writes:

> On Wed, Jun 02, 2010 at 02:50:16PM +0100, Mans Rullgard wrote:
>> The test for .align syntax was apparently unreliable with some compilers.
>> Using the .p2align directive instead avoids the need for this test.
> why bruteforce replace all ASMALIGN by p2align ?

Keeping the macro seems like useless obfuscation.

> i think its safer, at least for the time being to rather define
> it to p2align and only once we are sure all assemblers support
> this drop all ASMALIGN() ?

Can anyone name an assembler that doesn't support it?  Remember that
this is only used for x86 inline asm, so only gnu-compatible
compilers/assemblers need be considered.

That said, I'll happily do it in two steps.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list