[FFmpeg-devel] [PATCH] Replace ASMALIGN() with .p2align
Thu Jun 3 01:55:35 CEST 2010
Michael Niedermayer <michaelni at gmx.at> writes:
> On Wed, Jun 02, 2010 at 07:46:41PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> > On Wed, Jun 02, 2010 at 02:50:16PM +0100, Mans Rullgard wrote:
>> >> The test for .align syntax was apparently unreliable with some compilers.
>> >> Using the .p2align directive instead avoids the need for this test.
>> > why bruteforce replace all ASMALIGN by p2align ?
>> Keeping the macro seems like useless obfuscation.
>> > i think its safer, at least for the time being to rather define
>> > it to p2align and only once we are sure all assemblers support
>> > this drop all ASMALIGN() ?
>> Can anyone name an assembler that doesn't support it? Remember that
> i cant name one, but why did we use that macro in the first place if
> p2align was supported and working in all cases?
> i seem to faintly remember that someone said that no directive was supported
> everywere but i could be misremembering
GNU assembler is always GNU assembler. Even Apple supports it, so I
can't imagine anyone not having it.
>> this is only used for x86 inline asm, so only gnu-compatible
>> compilers/assemblers need be considered.
>> That said, I'll happily do it in two steps.
> i dont mind a single step if it works
I changed the macro to use .p2align. Nothing has broken so far, but I
don't mind waiting a few days for any errors to be reported.
mans at mansr.com
More information about the ffmpeg-devel