[FFmpeg-devel] [PATCH] provide AV_BASE64_SIZE() macro
Fri Jun 4 00:36:30 CEST 2010
On Thu, Jun 03, 2010 at 11:00:49PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Thu, Jun 03, 2010 at 10:39:52PM +0100, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> > On Thu, Jun 03, 2010 at 01:50:06PM -0700, Howard Chu wrote:
> >> >> Just for convenience...
> >> >
> >> > IMHO this is making the code harder to understand
> >> How so? It's an obscure calculation repeated multiple times. That is
> >> exactly the kind of situation functions and macros were invented for.
> > to me the calculation is clear,
> Because you happen to know exactly how base64 encoding works. This is
> IMO not a reasonable requirement to place on users of the interface.
its documented though, and i think its reasonable to expect users
to read the dox of what they use.
> Besides, the same rather complex calculation repeated numerous times
> is a recipe for trouble. Sooner or later, someone will get it wrong
> in one place. Then people will copy it from there, and the error will
> spread. It's much better to put it all in a macro.
i dont really see this as a big issue but if people prefer then iam not
against the macro
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 1
"Used only once" - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel