[FFmpeg-devel] [PATCH 4/8] metadata: add callbacks to conversion system.

Michael Niedermayer michaelni
Fri Jun 4 01:35:45 CEST 2010

On Wed, Jun 02, 2010 at 03:16:01PM +0200, Anton Khirnov wrote:
> diff --git a/libavformat/metadata.h b/libavformat/metadata.h
> index 309147d..24296c4 100644
> --- a/libavformat/metadata.h
> +++ b/libavformat/metadata.h
> @@ -42,6 +42,10 @@ typedef struct AVMetadataConvTable {
>  struct AVMetadataConv {
>      const AVMetadataConvTable *conv_table;
> +    /** Convert tags from src to generic/native format either a) in place, so they'll pass
> +     *  through the table next or b) remove them from src and store results in dst. */
> +    void (*conv2generic)(AVMetadata **src, AVMetadata **dst);
> +    void (*conv2native)( AVMetadata **src, AVMetadata **dst);
>  };

this does not seem very practical, each (de)muxer would just have a blackbox
convert to/from native and no 2 would be able to work with the same callback.
The system i suggested where AVMetadataConvTable entries have a convert
callback could share individual convertion functions like year<->date
between several (de)muxers. Also it would be less blackboxish as one would
know which tags are passed unchanged and which are changed


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100604/be4a69f3/attachment.pgp>

More information about the ffmpeg-devel mailing list