[FFmpeg-devel] [PATCH] Handle metadata in oma demuxer

Michael Niedermayer michaelni
Mon Jun 7 04:43:27 CEST 2010

On Sat, Jun 05, 2010 at 03:00:46PM +0200, Michael Karcher wrote:
> Am Samstag, den 05.06.2010, 00:51 +0200 schrieb Michael Niedermayer:> 
> > > This adds another layer of indirection, as instead of "ea", the
> > > *address* of "ea" is passed. I was essentially trying to avoid that.
> > > Also the memory access to magic[0] and magic[1] very likely will be a
> > > cache miss.
> > > 
> > > As it is "cold" code, performance probably isn't that critical, but as
> > > ffmpeg people seem to be very strict on performance, I tried to get the
> > > maximum out of it.
> > do you want to help optimizing h264?
> > it would be quite welcome (seriously)
> I don't have the time to scan the whole h264 stuff, but if you point me
> to special hot spots, I might take a look at it.

ask dark shikari, or if he doesnt have any immedeate ideas, i had a list
or 2 somewhere

> > for this here i think that more understandable code is better than
> > the lowest instruction count
> OK, adjusted patch attached.

and now please in 2 seperate patches, one for the ff_id3v2* changes
and one for oma

besides who wants to maintain the oma demuxer, theres noone listed in 

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100607/04924839/attachment.pgp>

More information about the ffmpeg-devel mailing list