[FFmpeg-devel] [PATCH] Do not override pix_fmt in rawdec.c
Mon Jun 7 17:04:59 CEST 2010
On Mon, Jun 07, 2010 at 02:30:34PM +0200, Tomas H?rdin wrote:
> On Mon, 2010-06-07 at 12:54 +0200, Michael Niedermayer wrote:
> > On Mon, Jun 07, 2010 at 11:01:23AM +0200, Tomas H?rdin wrote:
> > > Hi
> > >
> > > The attached patch adds a check for pix_fmt == PIX_FMT_NONE before
> > > attempting to guess it near rawdec.c:75. This enables demuxers to set it
> > > directly if known in advance (for example mxfdec.c).
> > >
> > > Patch passes regtests.
> > violates api
> > /**
> > * Pixel format, see PIX_FMT_xxx.
> > * - encoding: Set by user.
> > * - decoding: Set by libavcodec.
> > ^^^^^^^^^^^^^^^^^^^^^
> > this doesnt say set by "user" aka libavformat/app
> > */
> > enum PixelFormat pix_fmt;
> What would be a reasonable way to deal with it? Have a user_pix_fmt or
> something like that?
chnage the documentation and verify that all code using pix_fmt can handle it
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel