[FFmpeg-devel] [PATCH] mp4toannexb modification / improvement

Michael Niedermayer michaelni
Tue Jun 8 23:33:00 CEST 2010

On Tue, Jun 08, 2010 at 10:13:09PM +0200, Luca Abeni wrote:
> On 08/06/10 20:52, Michael Niedermayer wrote:
> [...]
>>>> while it is quite obscure but the + could overflow and lead to a
>>>> successfull allocation of a too small buffer
>>> Thanks for pointing this out... Would something like
>>>      uint64_t extra_size = (uint64_t)icodec->extradata_size +
>>>      if (extra_size>  INT_MAX)
>>>          goto fail;
>>> be enough to fix the problem?
>> yes
> Applied, then. Now, back to the mp4toannexb BSF patch... I attach an 
> improved version, which solves the extradata padding problem present in the 
> previous version. Is it ok, or should I fix something?

looks ok if tested


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100608/89ada1ec/attachment.pgp>

More information about the ffmpeg-devel mailing list