[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3

Michael Karcher ffmpeg
Fri Jun 11 00:44:45 CEST 2010


Am Donnerstag, den 10.06.2010, 23:55 +0200 schrieb Reimar D?ffinger:
> On Tue, Jun 08, 2010 at 12:06:40AM +0200, Michael Karcher wrote:
> > Am Montag, den 07.06.2010, 23:51 +0200 schrieb Reimar D?ffinger:
> > > > +    if(ff_id3v2_match(buf, ID3v2_EA3_MAGIC)) {
> > > > +        buf += ff_id3v2_tag_len(buf);
> > > > +    }
> > > > +
> > > > +    if (!memcmp(buf, "EA3", 3) && !buf[4] && buf[5] == EA3_HEADER_SIZE)
> > > Uh, no buffer size check?
> > > And missing space after "if" and unnecessary {}
> > Oh, good point. I hope the attached patch fixes these issues.
> This one is unchanged compared to before...

Oops, right. Thank you for notifying me. Real patch attached now.

Regards,
  Michael Karcher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id3v2_for_oma.diff
Type: text/x-patch
Size: 3180 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100611/89966272/attachment.bin>



More information about the ffmpeg-devel mailing list