[FFmpeg-devel] [PATCH] mkv support unknown size tags (issue 1991)

Aurelien Jacobs aurel
Fri Jun 11 21:54:33 CEST 2010

On Fri, Jun 11, 2010 at 07:29:48PM +0200, Reimar D?ffinger wrote:
> On Fri, Jun 11, 2010 at 06:46:58PM +0200, Aurelien Jacobs wrote:
> > On Tue, Jun 08, 2010 at 11:13:39PM +0200, Reimar D?ffinger wrote:
> > > Hello,
> > > it is still a bit rough but works.
> > 
> > Indeed, still a bit rough, an not totally correct, even though it works.
> For a 20 minute fix one can't really expect much more.
> And I suspect for pedants the id == MATROSKA_ID_CLUSTER isn't 100% what
> the spec says? (At least it uses a lot more words).

Indeed not. To be perfect, we should check if id is one of the valid ID
at the upper level. But this would add quite some complication, and I
don't know any use case for now, so I sticked to a simple version.
Anyway, checking for id == MATROSKA_ID_CLUSTER is safer that not
checking anything, because the element that we just encountered may
still be at the same level, but simply be unknown to current demuxer,
instead of being at a upper level.

> > Anyway, it was helpfull as it saved me some time to get on track.
> > I fixed this issue in a cleaner way.
> That was the main intention, making someone else pick it up, thanks.



More information about the ffmpeg-devel mailing list