[FFmpeg-devel] [PATCH] Add CRC check to ALS decoder

Justin Ruggles justin.ruggles
Sat Jun 12 21:08:42 CEST 2010

Thilo Borgmann wrote:

>>> CRC check for the ALS decoder.
>>> Works fine on my Intel-driven architecture. Any tests on other archs are
>>> of course appreciated.
>> I'm pretty sure the CRC for 24-bit source files are calculated based on
>> 3-byte samples, not 4-byte samples.  I don't think your patch would work
>> in this case.  Have you tested this with 24-bit source files?
> Sorry, indeed not. Revision 1 is tested against the 24 bit conformance
> files.
> Still, I would appreciate if someone can test it on a non-intel arch
> (before FATE does...).

Maybe the patch could be simplified and some macros avoided by doing
something like:

int swap = HAVE_BIGENDIAN != sconf->msb_first;
if (swap)


More information about the ffmpeg-devel mailing list