[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3

Michael Karcher ffmpeg
Sun Jun 13 00:25:13 CEST 2010

Am Samstag, den 12.06.2010, 19:44 +0200 schrieb Reimar D?ffinger:
> On Sat, Jun 12, 2010 at 06:41:48PM +0200, Michael Karcher wrote:
> > +    // This check cannot overflow as tag_len has at most 28 bits
> > +    if (p->buf_size + tag_len < tag_len + 5)
> ???
> Without overflows this is equivalent to p->buf_size < 5

I carefully reread all the other lines in the probe function and didn't
spot another stupid mistakes, so here we go again:

Add parsing of metadata in .oma/.aa3 files. They are just ID3v2 in
disguise starting with "ea3" instead of "ID3".

I'm really sorry for the time you invested for pointing me to that
stupid line.

  Michael Karcher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id3v2_for_oma.diff
Type: text/x-patch
Size: 3351 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100613/75c04870/attachment.bin>

More information about the ffmpeg-devel mailing list