[FFmpeg-devel] [PATCH] IFF: Add the HAM stuff

Ronald S. Bultje rsbultje
Tue Jun 15 00:34:34 CEST 2010


On Wed, May 26, 2010 at 5:24 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Michael Niedermayer a ?crit :
>> id like to get rid of the macros.
>> aka no grep #define matches ;)
> Ok, so fixed by making them functions. :-)

I didn't reply to this earlier, but a function vs. macro is of course
the same thing. What Michael meant is that the functionality should be
directly implemented where-ever it's called.

So no GET_PALETTE_DATA(extradata), but simply somethingconst int
presize = be16(extradata); uberconst uint8_t superconst * megaconst
palette_data = extradata + presize (possibly without the const :-) ).
This is fine, it is documented that the first bytes are something else
of size be16(firstword), so we can use that in the code. No reason to
hide it behind macros.


More information about the ffmpeg-devel mailing list