[FFmpeg-devel] [PATCH] RTP H.264 / AVC support

Howard Chu hyc
Wed Jun 16 10:08:49 CEST 2010

Luca Abeni wrote:
> It was just an idea... I attach a still-not-finished (works for me, but
> it's still unclean in some parts... In particular, I still need to reuse
> the avc_mp4_find_startcode() in other places) patch, which gives the idea.
> The good point about it is that it's simple.

Simple is good... It looks nice, and if it works, great.

A side comment - I know a smart compiler will eliminate common subexpressions 
for you, but it still bothers me to see "buf1 + size" everywhere, instead of 
just assigning it once at the beginning:
	uint8_t *end = buf1 + size;

Why do you always leave it spelled out like that? A *dumb* compiler will 
recompute it everywhere, which is of course stupid since it's constant in this 
context, but there are a lot of dumb compilers out there.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

More information about the ffmpeg-devel mailing list