[FFmpeg-devel] [PATCH] HTTP: Simplify the handling of chunked vs non-chunked posts

Josh Allmann joshua.allmann
Mon Jun 21 20:00:17 CEST 2010

On 21 June 2010 07:22, Martin Storsj? <martin at martin.st> wrote:
> Hi,
> On Mon, 21 Jun 2010, Ronald S. Bultje wrote:
>> Why do we have this is_chunked variable again? It should be chunksize
>> >=0 chunked, chunksize == -1 => unchuncked. Let's remove that
> We have it for setting whether chunked mode is desired for POSTs. I'll try
> to think it through and see if we can eliminate it completely,
> preferrabily in the setup with AVOptions as I posted in the other thread.

I added is_chunked because I wasn't sure it was safe to rely on
chunksize -- it is used primarily by http_read to keep track of the
response, so reusing that in http_write feels iffy. But if POST
reads/writes aren't usually interleaved, using chunksize should be OK.


More information about the ffmpeg-devel mailing list