[FFmpeg-devel] [PATCH] hqdn3d libavfilter port
Stefano Sabatini
stefano.sabatini-lala
Mon Jun 21 21:13:04 CEST 2010
On date Sunday 2010-06-20 18:08:25 -0700, Baptiste Coudurier encoded:
> Hi,
>
> $subject.
>
> --
> Baptiste COUDURIER
> Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> FFmpeg maintainer http://www.ffmpeg.org
> Index: libavfilter/vf_hqdn3d.c
> ===================================================================
> --- libavfilter/vf_hqdn3d.c (revision 0)
> +++ libavfilter/vf_hqdn3d.c (revision 0)
> @@ -0,0 +1,372 @@
> +/*
> + * Copyright (C) 2003 Daniel Moreno <comac at comac.darktech.org>
> + *
> + * This file is part of MPlayer.
> + *
> + * MPlayer is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * MPlayer is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with MPlayer; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
missing /** @file */
Also please add docs to libavfilter.texi and please add more doxies
when possible.
> +#include "avfilter.h"
> +#include "libavutil/pixdesc.h"
> +
> +#define PARAM1_DEFAULT 4.0
> +#define PARAM2_DEFAULT 3.0
> +#define PARAM3_DEFAULT 6.0
> +
> +typedef struct {
> + int Coefs[4][512*16];
> + unsigned int *Line;
> + unsigned short *Frame[3];
> + int hsub, vsub;
> +} HQDN3DContext;
general style note: avoid camelCasing, use plain_c_style, if_( and
for_( are preferred and I see weird indent in many places.
> +
> +static inline unsigned int LowPassMul(unsigned int PrevMul, unsigned int CurrMul, int* Coef)
> +{
> + // int dMul= (PrevMul&0xFFFFFF)-(CurrMul&0xFFFFFF);
> + int dMul= PrevMul-CurrMul;
> + unsigned int d=((dMul+0x10007FF)>>12);
> + return CurrMul + Coef[d];
> +}
> +
> +static void deNoiseTemporal(unsigned char *Frame, // mpi->planes[x]
> + unsigned char *FrameDest, // dmpi->planes[x]
pointless comments, they refer to MPlayer stuff
> + unsigned short *FrameAnt,
> + int W, int H, int sStride, int dStride,
> + int *Temporal)
> +{
> + long X, Y;
> + unsigned int PixelDst;
> +
> + for (Y = 0; Y < H; Y++){
> + for (X = 0; X < W; X++){
> + PixelDst = LowPassMul(FrameAnt[X]<<8, Frame[X]<<16, Temporal);
> + FrameAnt[X] = ((PixelDst+0x1000007F)>>8);
> + FrameDest[X]= ((PixelDst+0x10007FFF)>>16);
> + }
> + Frame += sStride;
> + FrameDest += dStride;
> + FrameAnt += W;
> + }
> +}
> +
> +static void deNoiseSpacial(unsigned char *Frame, // mpi->planes[x]
> + unsigned char *FrameDest, // dmpi->planes[x]
> + unsigned int *LineAnt, // vf->priv->Line (width bytes)
> + int W, int H, int sStride, int dStride,
> + int *Horizontal, int *Vertical)
> +{
> + long X, Y;
> + long sLineOffs = 0, dLineOffs = 0;
> + unsigned int PixelAnt;
> + unsigned int PixelDst;
> +
> + /* First pixel has no left nor top neighbor. */
> + PixelDst = LineAnt[0] = PixelAnt = Frame[0]<<16;
> + FrameDest[0]= ((PixelDst+0x10007FFF)>>16);
> +
> + /* First line has no top neighbor, only left. */
> + for (X = 1; X < W; X++) {
> + PixelDst = LineAnt[X] = LowPassMul(PixelAnt, Frame[X]<<16, Horizontal);
> + FrameDest[X]= ((PixelDst+0x10007FFF)>>16);
> + }
> +
> + for (Y = 1; Y < H; Y++) {
> + unsigned int PixelAnt;
> + sLineOffs += sStride, dLineOffs += dStride;
> + /* First pixel on each line doesn't have previous pixel */
> + PixelAnt = Frame[sLineOffs]<<16;
> + PixelDst = LineAnt[0] = LowPassMul(LineAnt[0], PixelAnt, Vertical);
> + FrameDest[dLineOffs]= ((PixelDst+0x10007FFF)>>16);
> +
> + for (X = 1; X < W; X++) {
> + unsigned int PixelDst;
> + /* The rest are normal */
> + PixelAnt = LowPassMul(PixelAnt, Frame[sLineOffs+X]<<16, Horizontal);
> + PixelDst = LineAnt[X] = LowPassMul(LineAnt[X], PixelAnt, Vertical);
> + FrameDest[dLineOffs+X]= ((PixelDst+0x10007FFF)>>16);
> + }
> + }
> +}
> +
> +static void deNoise(unsigned char *Frame, // mpi->planes[x]
> + unsigned char *FrameDest, // dmpi->planes[x]
> + unsigned int *LineAnt, // vf->priv->Line (width bytes)
> + unsigned short **FrameAntPtr,
> + int W, int H, int sStride, int dStride,
> + int *Horizontal, int *Vertical, int *Temporal)
> +{
> + long X, Y;
> + long sLineOffs = 0, dLineOffs = 0;
> + unsigned int PixelAnt;
> + unsigned int PixelDst;
> + unsigned short* FrameAnt=(*FrameAntPtr);
> +
> + if(!FrameAnt){
> + (*FrameAntPtr) = FrameAnt = av_malloc(W*H*sizeof(unsigned short));
> + for (Y = 0; Y < H; Y++) {
> + unsigned short* dst=&FrameAnt[Y*W];
> + unsigned char* src=Frame+Y*sStride;
> + for (X = 0; X < W; X++) dst[X]=src[X]<<8;
> + }
> + }
> +
> + if(!Horizontal[0] && !Vertical[0]){
> + deNoiseTemporal(Frame, FrameDest, FrameAnt,
> + W, H, sStride, dStride, Temporal);
> + return;
> + }
> + if(!Temporal[0]){
> + deNoiseSpacial(Frame, FrameDest, LineAnt,
> + W, H, sStride, dStride, Horizontal, Vertical);
> + return;
> + }
> +
> + /* First pixel has no left nor top neighbor. Only previous frame */
> + LineAnt[0] = PixelAnt = Frame[0]<<16;
> + PixelDst = LowPassMul(FrameAnt[0]<<8, PixelAnt, Temporal);
> + FrameAnt[0] = ((PixelDst+0x1000007F)>>8);
> + FrameDest[0]= ((PixelDst+0x10007FFF)>>16);
> +
> + /* First line has no top neighbor. Only left one for each pixel and
> + * last frame */
> + for (X = 1; X < W; X++) {
> + LineAnt[X] = PixelAnt = LowPassMul(PixelAnt, Frame[X]<<16, Horizontal);
> + PixelDst = LowPassMul(FrameAnt[X]<<8, PixelAnt, Temporal);
> + FrameAnt[X] = ((PixelDst+0x1000007F)>>8);
> + FrameDest[X]= ((PixelDst+0x10007FFF)>>16);
> + }
> +
> + for (Y = 1; Y < H; Y++) {
> + unsigned int PixelAnt;
> + unsigned short* LinePrev=&FrameAnt[Y*W];
> + sLineOffs += sStride, dLineOffs += dStride;
> + /* First pixel on each line doesn't have previous pixel */
> + PixelAnt = Frame[sLineOffs]<<16;
> + LineAnt[0] = LowPassMul(LineAnt[0], PixelAnt, Vertical);
> + PixelDst = LowPassMul(LinePrev[0]<<8, LineAnt[0], Temporal);
> + LinePrev[0] = ((PixelDst+0x1000007F)>>8);
> + FrameDest[dLineOffs]= ((PixelDst+0x10007FFF)>>16);
> +
> + for (X = 1; X < W; X++) {
> + unsigned int PixelDst;
> + /* The rest are normal */
> + PixelAnt = LowPassMul(PixelAnt, Frame[sLineOffs+X]<<16, Horizontal);
> + LineAnt[X] = LowPassMul(LineAnt[X], PixelAnt, Vertical);
> + PixelDst = LowPassMul(LinePrev[X]<<8, LineAnt[X], Temporal);
> + LinePrev[X] = ((PixelDst+0x1000007F)>>8);
> + FrameDest[dLineOffs+X]= ((PixelDst+0x10007FFF)>>16);
> + }
> + }
> +}
> +
> +static void start_frame(AVFilterLink *link, AVFilterPicRef *picref)
> +{
> + HQDN3DContext *hqdn3d = link->dst->priv;
> + AVFilterLink *outlink = link->dst->outputs[0];
> + AVFilterPicRef *outpicref;
> +
> + hqdn3d->hsub = av_pix_fmt_descriptors[link->format].log2_chroma_w;
> + hqdn3d->vsub = av_pix_fmt_descriptors[link->format].log2_chroma_h;
> +
> + outpicref = avfilter_get_video_buffer(outlink, AV_PERM_WRITE, outlink->w, outlink->h);
> + outpicref->pts = picref->pts;
> + outpicref->pos = picref->pos;
> + outpicref->interlaced = picref->interlaced;
> + outpicref->top_field_first = picref->top_field_first;
we should find some sort of macro for this, this is going to break
when we'll add more fields and will forget to update filters code...
> +
> + outlink->outpic = outpicref;
> +
> + avfilter_start_frame(outlink, avfilter_ref_pic(outpicref, ~0));
> +}
> +
> +static void null_draw_slice(AVFilterLink *link, int y, int h, int slice_dir)
> +{
> +}
> +
> +
> +static int query_formats(AVFilterContext *ctx)
> +{
> + static const enum PixelFormat pix_fmts[] = {
> + PIX_FMT_YUV420P, PIX_FMT_YUV422P, PIX_FMT_YUV411P,
> + };
> +
> + avfilter_set_common_formats(ctx, avfilter_make_format_list(pix_fmts));
> +
> + return 0;
> +}
> +
> +static int config_input(AVFilterLink *link)
> +{
> + HQDN3DContext *hqdn3d = link->dst->priv;
> +
> + hqdn3d->Line = av_malloc(link->w * sizeof(*hqdn3d->Line));
> + if (!hqdn3d->Line)
> + return -1;
AVERROR(ENOMEM)
> +
> + return 0;
> +}
> +
> +static void PrecalcCoefs(int *Ct, double Dist25)
> +{
> + int i;
> + double Gamma, Simil, C;
> +
> + Gamma = log(0.25) / log(1.0 - Dist25/255.0 - 0.00001);
> +
> + for (i = -255*16; i <= 255*16; i++) {
> + Simil = 1.0 - FFABS(i) / (16*255.0);
> + C = pow(Simil, Gamma) * 65536.0 * (double)i / 16.0;
> + Ct[16*256+i] = (C<0) ? (C-0.5) : (C+0.5);
> + }
> +
> + Ct[0] = (Dist25 != 0);
> +}
> +
> +
> +static int init(AVFilterContext *ctx, const char *args, void *opaque)
> +{
> + HQDN3DContext *hqdn3d = ctx->priv;
> + double LumSpac, LumTmp, ChromSpac, ChromTmp;
> + double Param1, Param2, Param3, Param4;
> +
> + if (args) {
> + switch(sscanf(args, "%lf:%lf:%lf:%lf",
> + &Param1, &Param2, &Param3, &Param4)) {
these could have more significant names, the same for the _DEFAULT
macros.
> + case 0:
> + LumSpac = PARAM1_DEFAULT;
> + LumTmp = PARAM3_DEFAULT;
> +
> + ChromSpac = PARAM2_DEFAULT;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + break;
> + case 1:
> + LumSpac = Param1;
> + LumTmp = PARAM3_DEFAULT * Param1 / PARAM1_DEFAULT;
> +
> + ChromSpac = PARAM2_DEFAULT * Param1 / PARAM1_DEFAULT;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + break;
> + case 2:
> + LumSpac = Param1;
> + LumTmp = PARAM3_DEFAULT * Param1 / PARAM1_DEFAULT;
> +
> + ChromSpac = Param2;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + break;
> + case 3:
> + LumSpac = Param1;
> + LumTmp = Param3;
> +
> + ChromSpac = Param2;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + break;
> + case 4:
> + LumSpac = Param1;
> + LumTmp = Param3;
> +
> + ChromSpac = Param2;
> + ChromTmp = Param4;
> + break;
> + default:
> + LumSpac = PARAM1_DEFAULT;
> + LumTmp = PARAM3_DEFAULT;
> +
> + ChromSpac = PARAM2_DEFAULT;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + }
> + } else {
> + LumSpac = PARAM1_DEFAULT;
> + LumTmp = PARAM3_DEFAULT;
> +
> + ChromSpac = PARAM2_DEFAULT;
> + ChromTmp = LumTmp * ChromSpac / LumSpac;
> + }
> +
> + PrecalcCoefs(hqdn3d->Coefs[0], LumSpac);
> + PrecalcCoefs(hqdn3d->Coefs[1], LumTmp);
> + PrecalcCoefs(hqdn3d->Coefs[2], ChromSpac);
> + PrecalcCoefs(hqdn3d->Coefs[3], ChromTmp);
> +
> + return 0;
> +}
> +
> +static void end_frame(AVFilterLink *link)
> +{
> + HQDN3DContext *hqdn3d = link->dst->priv;
> + AVFilterPicRef *outpic = link->dst->outputs[0]->outpic;
> + AVFilterPicRef *pic = link->cur_pic;
> + int cw = pic->w >> hqdn3d->hsub;
> + int ch = pic->h >> hqdn3d->vsub;
> +
> + deNoise(pic->data[0], outpic->data[0],
> + hqdn3d->Line, &hqdn3d->Frame[0], pic->w, pic->h,
> + pic->linesize[0], outpic->linesize[0],
> + hqdn3d->Coefs[0],
> + hqdn3d->Coefs[0],
> + hqdn3d->Coefs[1]);
> + deNoise(pic->data[1], outpic->data[1],
> + hqdn3d->Line, &hqdn3d->Frame[1], cw, ch,
> + pic->linesize[1], outpic->linesize[1],
> + hqdn3d->Coefs[2],
> + hqdn3d->Coefs[2],
> + hqdn3d->Coefs[3]);
> + deNoise(pic->data[2], outpic->data[2],
> + hqdn3d->Line, &hqdn3d->Frame[2], cw, ch,
> + pic->linesize[2], outpic->linesize[2],
> + hqdn3d->Coefs[2],
> + hqdn3d->Coefs[2],
> + hqdn3d->Coefs[3]);
> +
> + avfilter_draw_slice(link->dst->outputs[0], 0, link->cur_pic->h, 1);
> +
> + avfilter_end_frame(link->dst->outputs[0]);
> + avfilter_unref_pic(link->cur_pic);
> +}
> +
> +static void uninit(AVFilterContext *ctx)
> +{
> + HQDN3DContext *hqdn3d = ctx->priv;
> +
> + if (hqdn3d->Line)
> + av_freep(&hqdn3d->Line);
> + if (hqdn3d->Frame[0])
> + av_freep(&hqdn3d->Frame[0]);
> + if (hqdn3d->Frame[1])
> + av_freep(&hqdn3d->Frame[1]);
> + if (hqdn3d->Frame[2])
> + av_freep(&hqdn3d->Frame[2]);
for
> +}
> +
> +AVFilter avfilter_vf_hqdn3d = {
> + .name = "hqdn3d",
> + .description = "High Quality 3D Denoiser",
description describes what the filter does, is not a long name
(e.g. "Apply an high quality 3D denoiser.").
> +
> + .priv_size = sizeof(HQDN3DContext),
> + .init = init,
> + .uninit = uninit,
> + .query_formats = query_formats,
> +
> + .inputs = (AVFilterPad[]) {{ .name = "default",
> + .type = AVMEDIA_TYPE_VIDEO,
> + .start_frame = start_frame,
> + .draw_slice = null_draw_slice,
> + .config_props = config_input,
> + .end_frame = end_frame },
> + { .name = NULL}},
> +
> + .outputs = (AVFilterPad[]) {{ .name = "default",
> + .type = AVMEDIA_TYPE_VIDEO },
> + { .name = NULL}},
> +};
Regards.
--
FFmpeg = Formidable Freak Murdering Picky Embarassing God
More information about the ffmpeg-devel
mailing list