[FFmpeg-devel] [PATCH] VP8 decoder

Måns Rullgård mans
Tue Jun 22 16:42:06 CEST 2010


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> +#ifndef PACK4x8
> +#define PACK4x8(a,b,c,d) \
> +    HAVE_BIGENDIAN ? (a << 24) | (b << 16) | (c << 8) | d : \
> +                     (d << 24) | (c << 16) | (b << 8) | a
> +#endif

This is missing parens everywhere.  I'm also uncertain whether it
might not be better to use #if HAVE_BIGENDIAN instead.  You never know
with compilers...

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list