[FFmpeg-devel] [PATCH 03/12] mdct: remove temporary array in ff_kbd_window_init()

Michael Niedermayer michaelni
Thu Jun 24 01:48:53 CEST 2010

On Thu, Jun 24, 2010 at 12:37:34AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Wed, Jun 23, 2010 at 06:26:41PM +0100, Mans Rullgard wrote:
> >> The intermediate values can be stored in the output array, avoiding
> >> the need for a variable-length array.
> >
> > this can write into static arrays and thus introduces a race condition
> Quite.  Which would you prefer then, 1) malloc/free or, 2) always
> allocating a [1024] array (largest size used)?  Option 2 would use 4k
> (float) or 8k (double) of stack space, which is IMO a bit larger than
> what's comfortable.  It would of course not change anything compared
> to current code so should be safe.

as its speed irrelevant init code iam ok with malloc()


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100624/28391eab/attachment.pgp>

More information about the ffmpeg-devel mailing list