[FFmpeg-devel] [PATCH] Fix segfault in x11grab when drawing Cursor on Xservers that don't support the XFixes extension

Brenden Bain brenden.bain
Thu Jun 24 14:12:25 CEST 2010

On Thu, 2010-06-24 at 12:44 +0100, M?ns Rullg?rd wrote:
> Brenden Bain <brenden.bain at gmail.com> writes:
> > @@ -388,7 +399,11 @@
> >      }
> >  
> >      if(!s->nomouse){
> > -        paint_mouse_pointer(image, s);
> > +        if (!paint_mouse_pointer(image, s)) {
> > +            /* An error occured and will likely occur again. Just disable mouse capture from now on */
> That comment is superfluous.  Anyone with half a brain can see pointer
> capture is being turned off.

I am trying to document the intent of the line. It was not obvious to me
why one error would turn mouse capture off (though many would argue that
I only have half a brain). Maybe some bad Xserver returns NULL when you
move the cursor off the screen and continues to work later. I just
wanted to document the decision that was made. I am happy to take it out
if it bugs. 

Thanks for your patience and help.


More information about the ffmpeg-devel mailing list