[FFmpeg-devel] [PATCH] RTP H.264 / AVC support
Sun Jun 27 08:58:50 CEST 2010
On 27/06/10 00:10, Howard Chu wrote:
>>>> I was going to commit the rtpenc.* part of the patch (adding
>>>> nal_length_size to struct RTPMuxContext), but then I noticed:
>>>> s->nal_length_size = ((*(((char*)(st->codec->extradata))+4))&0x03)+1;
>>>> and I am wondering why casting extradata to (char *)... I think this
>>>> can be simplifed to
>>>> s->nal_length_size = (st->codec->extradata& 0x03) + 1;
>>>> what do you think?
>>> Sounds good.
>> Ok, good; I'll commit it later.
> Ping... It's now much later; I'm getting lots of emails from Android
> users who can't get ffserver working because this patch is missing. When
> are you planning to commit it?
The rtpenc.* patch is in. It turned out that it was slightly incorrect,
and I fixed it after committing.
What's missing is the rtpenc_h264.c patch, which still needs some
discussion about what can/should be exported from h264.c, and how.
P.S.: I am currently in vacation, so I might be unresposive with emails.
More information about the ffmpeg-devel