[FFmpeg-devel] [PATCH] Change broken -Werror=implicit flag in configure into working flag

[Martin Storsjö]

On Sun, 27 Jun 2010, M?ns Rullg?rd wrote:

> Eli Friedman <eli.friedman at gmail.com> writes:
> 
> > Patch attached.  At least with gcc 4.4.3, -Werror=implicit does
> > nothing, and -Werror=implicit-int does not work with -std=c99.
> >
> > The configure change exposes an error in ffserver.c, so I patched that
> > as well; I'm not sure if this is the best fix, though.  The function
> > in question is ff_url_split.
> >
> > -Eli
> >
> > Index: ffserver.c
> > ===================================================================
> > --- ffserver.c	(revision 23802)
> > +++ ffserver.c	(working copy)
> > @@ -29,6 +29,7 @@
> >  #include <strings.h>
> >  #include <stdlib.h>
> >  #include "libavformat/avformat.h"
> > +#include "libavformat/internal.h"
> 
> That is strictly verboten.  I've tried to make people fix this
> properly, but they all ignored me.
> 
> >  #include "libavformat/network.h"
> >  #include "libavformat/os_support.h"
> >  #include "libavformat/rtpdec.h"
> > Index: configure
> > ===================================================================
> > --- configure	(revision 23802)
> > +++ configure	(working copy)
> > @@ -2702,7 +2702,7 @@
> >      add_cflags -msg_disable unreachcode
> >  elif enabled gcc; then
> >      check_cflags -fno-tree-vectorize
> > -    check_cflags -Werror=implicit
> > +    check_cflags -Werror=implicit-function-declaration
> >      check_cflags -Werror=missing-prototypes
> >  elif enabled clang; then
> >      check_cflags -Qunused-arguments
> 
> I'd like to do that, but can't until ffserver is fixed.  And no,
> including lavf private headers is not allowed.  The API must be fixed.

Stefano sent a patch doing that, making both ff_url_split and ff_url_join 
public, that stalled in a discussion on details regarding ff_url_join. 
The part making ff_url_split public should be ok as far as I remember, 
though.

// Martin