[FFmpeg-devel] [RFC] motion_est: avoid implicit truncation warnings

Måns Rullgård mans
Sun Jun 27 16:13:11 CEST 2010

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Jun 27, 2010 at 12:55:23PM +0200, Reimar D?ffinger wrote:
>> Hello,
>> maybe a bit ugly to add an extra macro, but using the changed macro
>> everywhere produces very different code at least on x86_64.
> This can be done cleaner with av_builtin_constant_p()

Which doesn't work everywhere, and old versions of gcc don't allow it
in static initialisers.  Also, with compilers that do not support it,
expressions like (0? non_constant: constant) are not valid as integer
constant expressions.  There is thus no way it can be used here.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list