[FFmpeg-devel] [PATCH] strict-aliasing-safe aes.c

[Reimar Döffinger]

On Mon, Jun 28, 2010 at 10:02:15PM +0200, Michael Niedermayer wrote:
> On Mon, Jun 28, 2010 at 05:55:30PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > this uses AV_WN32A, AV_WN64A etc. macros.
> > The generated code is the same on x86_64 (assuming I did not mess up that test).
> 
> >  aes.c |   20 +++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> > 76705b63949d4abbe51b0d7d59537045ae91179a  aesalias.diff
> 
> this makes the code unreadable, iam thus against it.

Well, what is the alternative? The current code seems to not work with some compilers.

> Also its missing a benchmark

The generated binary is identical, what is the point of benchmarking?
Unless you expect me to be better at benchmarking than objdump -d and
diff -u, which is quite an unreasonable expectation.