[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions

Måns Rullgård mans
Wed Jun 30 00:36:50 CEST 2010

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Tue, Jun 29, 2010 at 01:02:05PM -0700, Baptiste Coudurier wrote:
>> On 6/29/10 11:51 AM, Reimar D?ffinger wrote:
>> >On Tue, Jun 29, 2010 at 08:30:01PM +0200, Reimar D?ffinger wrote:
>> >>Hello,
>> >>currently mxfdec assumes that it can unpunished pass more arguments to functions
>> >>than they were declared with.
>> >>This is not true in general, in particular not for stdcall.
>> >>While I am not aware of any FFmpeg platform using it, IMHO this code is still
>> >>wrong.
>> >>Attached is a patch that fixes it, and I think it is not particularly bad.
>> >>It also fixes the last remaining warnings ("function declaration is not a prototype")
>> >>in that file.
>> I don't have this warning.
>> gcc version 4.4.4 (Ubuntu 4.4.4-6ubuntu2)
> Right, I had been using -Wstrict-prototypes

Once this is fixed I'll make that an error.  We don't want this
happening again.

>> >+#define METADATA_READ_FUNC(name) int name(void *arg, ByteIOContext *pb, int tag, int size, UID uid)
>> I don't like the #define.
> Well, the alternative is having to change every single read function
> manually in case you'd ever need an additional parameter.
> And I found it very hard to find them.

I'm with Reimar on this one.  If you don't like it, fix it in some
other way, but don't just say no.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list